Start adding lint rules for 40px default size #64410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
mirka
commented
Aug 10, 2024
| 'FontSizePicker', | ||
| ].map( ( componentName ) => ( { | ||
| // Falsy `__next40pxDefaultSize` without a non-default `size` prop. | ||
| selector: `JSXOpeningElement[name.name="${ componentName }"]:not(:has(JSXAttribute[name.name="__next40pxDefaultSize"][value.expression.value!=false])):not(:has(JSXAttribute[name.name="size"][value.value!="default"]))`, |
There was a problem hiding this comment.
Should error
<Component />
<Component __next40pxDefaultSize={ false } />
<Component size="default" />Should not error
<Component __next40pxDefaultSize />
<Component size="__unstable-default" />
<Component size="small" />
|
Flaky tests detected in 0fc2b7e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10327521886
|
|
@mirka is this one ready for review? |
Yes, sorry, forgot to tag reviewers! |
tyxla
approved these changes
Aug 13, 2024
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Start adding lint rules for 40px default size * Make stricter Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63871
What?
Adds lint rules for
__next40pxDefaultSizeprop adherence on the following components:Why?
These components currently don't have any violations, so this prevents accidental backslides when new instances are newly introduced into the codebase.
Testing Instructions
See code comments.